hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12684) Add new AsyncRpcClient
Date Thu, 18 Dec 2014 19:17:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252072#comment-14252072

stack commented on HBASE-12684:

Here is a quick review. Hope it helps some.

Why out of interest the below change?

830	    return (value != null)? Integer.valueOf(value).intValue(): DEFAULT_TTL;	830	    return
(value != null) ? Integer.parseInt(value) : DEFAULT_TTL;

The below is not a repeat because we are replacing old rpc with this new one?

81	  private static final byte[] MAGIC = new byte[] { 'H', 'B', 'a', 's' };

This looks great: 201	                f.channel().pipeline().addFirst(saslHandler);

This change is good too:

150	      extends AbstractRpcClient.BlockingRpcChannelImplementation {	149	      extends RpcClientImpl.BlockingRpcChannelImplementation

Patch looks great.  On the tests that are zombies, they are probably missing (timeout=XX)
annotations after @Test.  Feel free to add if it will help you debug.  When you get a chance,
make a list of what you will be able to remove after this is all working. I love removing

Thanks [~jurmous]

> Add new AsyncRpcClient
> ----------------------
>                 Key: HBASE-12684
>                 URL: https://issues.apache.org/jira/browse/HBASE-12684
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12684-v1.patch, HBASE-12684-v2.patch, HBASE-12684-v3.patch,
HBASE-12684-v4.patch, HBASE-12684-v5.patch, HBASE-12684.patch
> With the changes in HBASE-12597 it is possible to add new RpcClients. This issue is about
adding a new Async RpcClient which would enable HBase to do non blocking protobuf service
> Besides delivering a new AsyncRpcClient I would also like to ask the question what it
would take to replace the current RpcClient? This would enable to simplify async code in some
next issues.

This message was sent by Atlassian JIRA

View raw message