hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12682) compaction thread throttle value is not correct in hbase-default.xml
Date Mon, 15 Dec 2014 20:20:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247168#comment-14247168
] 

Hadoop QA commented on HBASE-12682:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12687101/HBASE-12682-master.patch
  against master branch at commit 555d14ed4525f9a0d533b90e20afcce0dc8c595f.
  ATTACHMENT ID: 12687101

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12088//console

This message is automatically generated.

> compaction thread throttle value is not correct in hbase-default.xml
> --------------------------------------------------------------------
>
>                 Key: HBASE-12682
>                 URL: https://issues.apache.org/jira/browse/HBASE-12682
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12682-master.patch
>
>
> While doing some compaction tuning and looking up some of the parameters, I noticed that
hbase.regionserver.thread.compaction.throttle default value in the documentation and in hbase-site.xml
seems to be off the mark.
> {code}
>   <property>
>     <name>hbase.regionserver.thread.compaction.throttle</name>
>     <value>2560</value>
>     <description>There are two different thread pools for compactions, one for
large compactions and
>       the other for small compactions. This helps to keep compaction of lean tables (such
as
>         <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger
than this threshold, it
>       goes into the large compaction pool. In most cases, the default value is appropriate.
Default:
>       2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size (which defaults
to 128).
>       The value field assumes that the value of hbase.hregion.memstore.flush.size is
unchanged from
>       the default.</description>
>   </property>
> {code}
> It should be in bytes. Or am I missing anything?
> It is not a problem in 0.98 since the property is not in hbase-site.xml over there. It
is obtained dynamically:
> {code}
> throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
>           2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message