hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12674) Add permission check to getNamespaceDescriptor()
Date Thu, 11 Dec 2014 17:29:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242824#comment-14242824
] 

Hadoop QA commented on HBASE-12674:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12686601/HBASE-12674-v0.patch
  against master branch at commit f67162547d2891ba7e08ad912336f78fae24322b.
  ATTACHMENT ID: 12686601

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 2089 checkstyle
errors (more than the master's current 2088 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +  public void preGetNamespaceDescriptor(ObserverContext<MasterCoprocessorEnvironment>
ctx, String namespace)
+    assertTrue("Test namespace descriptor should have been called", cp.wasGetNamespaceDescriptorCalled());
+    assertTrue("Test namespace descriptor should have been called", cp.wasGetNamespaceDescriptorCalled());
+    assertTrue("Test namespace descriptor should have been called", cp.wasGetNamespaceDescriptorCalled());

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.sqoop.test.minicluster.TomcatSqoopMiniCluster.stop(TomcatSqoopMiniCluster.java:123)
	at org.apache.sqoop.test.testcases.TomcatTestCase.stopServer(TomcatTestCase.java:119)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12049//console

This message is automatically generated.

> Add permission check to getNamespaceDescriptor()
> ------------------------------------------------
>
>                 Key: HBASE-12674
>                 URL: https://issues.apache.org/jira/browse/HBASE-12674
>             Project: HBase
>          Issue Type: Bug
>          Components: master, security
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: HBASE-12674-v0.patch
>
>
> Add permission check to getNamespaceDescriptor()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message