hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-12673) Add a UT to read mob file when the mob hfile moving from the mob dir to the archive dir
Date Tue, 16 Dec 2014 14:43:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248323#comment-14248323
] 

Jonathan Hsieh edited comment on HBASE-12673 at 12/16/14 2:43 PM:
------------------------------------------------------------------

Thanks for the pointer in HMobStore @ 312.  The retry there should address the situation I
was concerned about.  Looking at that code again one other concern comes up -- do you know
if line 319 in there will throw another exception if we got the FNFE on line 313?  (we'd have
an open file instance that got moved --- not sure what would happen on close on line 319).
 Can we change it so that we capture the other exceptions that could be caught there [1] and
then try the next location?

HFileLink essentially makes this file redirection mechanism transparent and would potentially
make the code easier to follow.  I'd prefer it if we could use that code so if we find other
cases we can just fix it in one centralized place. 

[1] https://github.com/apache/hbase/blob/hbase-11339/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java#L124


was (Author: jmhsieh):
Thanks for the pointer in HMobStore @ 312.  The retry there should address the situation I
was concerned about.  Looking at that code again one other concern comes up -- do you know
if line 319 in there will throw another exception if we got the FNFE on line 313?  (we'd have
an open file instance that got moved --- not sure what would happen on close on line 319).
 Can we change it so that we capture the other exceptions that could be caught there [1] and
then try the next location?

HFileLink essentially makes this file redirection mechanism transparent and would potentially
make the code easier to follow.    If you can convince me that the line 319 concerns isn't
a problem with a unit tests I'll drop the HFileLink request.  As it stands it might be a little
difficult to mock it out but would be helpful.

[1] https://github.com/apache/hbase/blob/hbase-11339/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FileLink.java#L124

> Add a UT to read mob file when the mob hfile moving from the mob dir to the archive dir
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-12673
>                 URL: https://issues.apache.org/jira/browse/HBASE-12673
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: hbase-11339
>            Reporter: Jiajia Li
>            Assignee: Jiajia Li
>             Fix For: hbase-11339
>
>         Attachments: HBASE-12673.patch
>
>
> add a unit test to scan the cloned table when deleting the original table, and the steps
as following:
> 1) create a table with mobs, 
> 2) snapshot it, 
> 3) clone it as a a different table
> 4) have a read workload on the snapshot
> 5) delete the original table



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message