hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12665) When aborting, dump metrics
Date Tue, 09 Dec 2014 23:25:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240277#comment-14240277
] 

Jean-Daniel Cryans commented on HBASE-12665:
--------------------------------------------

[~stack] From a usability standpoint, how many lines do you get when dumping the metrics?
Looks like it would go in the hundreds (also you are showing the master's metrics, standalone?).
What I liked about what we had before was that it was concise and contained mostly stuff I
was interested in, whereas now we seem to be getting all the histograms. Also, it goes to
stdout instead of being logged, was that intentional? I'm not sure how that's gonna come out
if there's loads of stuff being logged (like it usually is when a RS is aborting), it might
get mixed a bit. Finally, it would be nice to get some description of what's being dumped.
I was actually confused when I saw this part:

{noformat}
2014-12-09 13:44:21,244 FATAL [main] regionserver.HRegionServer(1927): RegionServer abort:
loaded coprocessors are: [org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint]
{
  "beans" : [ {
{noformat}

It felt like the metrics were a continuation of the coprocessors printout. I'm easy to confuse
so that might just be me.

Thanks for picking this up. In this time of the year, family values are more important than
ever.

> When aborting, dump metrics
> ---------------------------
>
>                 Key: HBASE-12665
>                 URL: https://issues.apache.org/jira/browse/HBASE-12665
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>            Reporter: stack
>            Assignee: stack
>             Fix For: 1.0.0, 2.0.0, 0.98.9
>
>         Attachments: 0001-First-cut.patch, 0001-HBASE-12665-When-aborting-dump-metrics.patch
>
>
> We used to dump out all metrics when we were exiting on abort. Was of use debugging why
the abort.  We used to have this.  [~jdcryans] noticed it was dropped by his brother [~eclark]
over in HBASE-6410 "Move RegionServer Metrics to metrics2" To stop the two brothers fighting
I intervened with this patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message