hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12663) unify getTableDescriptors() and listTableDescriptorsByNamespace()
Date Tue, 09 Dec 2014 18:50:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239827#comment-14239827
] 

Hadoop QA commented on HBASE-12663:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12686033/HBASE-12663-v0.patch
  against master branch at commit 51ab8a05b99a13943343f0b55f2dae282a574c68.
  ATTACHMENT ID: 12686033

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.balancer.TestDefaultLoadBalancer

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12020//console

This message is automatically generated.

> unify getTableDescriptors() and listTableDescriptorsByNamespace()
> -----------------------------------------------------------------
>
>                 Key: HBASE-12663
>                 URL: https://issues.apache.org/jira/browse/HBASE-12663
>             Project: HBase
>          Issue Type: Bug
>          Components: master, security
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>         Attachments: HBASE-12663-v0.patch
>
>
> currently we have getTableDescriptors()/listTableNames()
> and listTableDescriptorsByNamespace()/listTableNamesByNamespace()
> which are just filtering by namespace.
> The first two are already able to filter tables by regex,
> and there is also an ACL check which shows only the table the user have access to,
> while the namespace version just return a list without any ACLs check.
> to me there is no point to keep the *ByNamespace() version on the server side, 
> since the "base" version must be able to do the filtering by
> namespace and the ACLs check must be the same for both anyway.
> or at least we can just call the base version with the ns filtering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message