hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
Date Mon, 15 Dec 2014 01:45:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246227#comment-14246227
] 

Enis Soztutar commented on HBASE-12651:
---------------------------------------

Sorry I was not part of the original review. This seems fine for 1.0, but I am concerned about
the hbase-site2.xml and the unit test. hbase-site2.xml will diverge from hbase-site.xml very
quickly since devs will not know about this file, and will not change it then they add a new
conf option. Then, when this test overwrites the file, concurrently running tests will be
affected. I think the unit test should be changed so that it dynamically re-writes the file
with the added config option rather than committing the hbase-site2.xml file. 

> Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12651
>                 URL: https://issues.apache.org/jira/browse/HBASE-12651
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 1.0.0
>
>         Attachments: 12651-1.0.txt
>
>
> HBASE-12559 added support for online configuration update of load balancer.
> This JIRA backports this to branch-1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message