hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12631) Backport HBASE-12576 (Add metrics for rolling the HLog if there are too few DN's in the write pipeline) to 0.98
Date Wed, 10 Dec 2014 20:43:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241696#comment-14241696
] 

Sean Busbey commented on HBASE-12631:
-------------------------------------

In 0.98 MetricsWAL isn't a WALActionsListener, so it isn't on the list that is notified about
roll requests. 

I think this addition to FSHLog.java will make everything do what you want.

{code}
private void requestLogRoll(boolean tooFewReplicas) {
    if (!this.listeners.isEmpty()) {
      for (WALActionsListener i: this.listeners) {
        i.logRollRequested(tooFewReplicas);
      }
    }
+  this.metrics.logRollRequested(tooFewReplicas);
  }
{code}

I'm not sure how much we should care about the test gap to cover this.

> Backport HBASE-12576 (Add metrics for rolling the HLog if there are too few DN's in the
write pipeline) to 0.98
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12631
>                 URL: https://issues.apache.org/jira/browse/HBASE-12631
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.98.9
>
>         Attachments: HBASE-12631-0.98.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message