hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-12619) Backport HBASE-11639 (Replicate the visibility of Cells as strings) to 0.98
Date Thu, 04 Dec 2014 19:07:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234480#comment-14234480
] 

Andrew Purtell edited comment on HBASE-12619 at 12/4/14 7:06 PM:
-----------------------------------------------------------------

I made a pass over this and it seems fine. Let me see about committing this today, it should
be in place ahead of HBASE-11764 because there's a small conflict with tag type allocation.
(I'll fix that in HBASE-11764). Will take a closer look then.

One higher level question I have about this whole design is what happens if we want to replicate
visibility tags as Strings over an existing custom ReplicationEndpoint? That won't be guaranteed
today because an endpoint is implemented by a single class, there's no opportunity for mixing
in functionality, each implementation must take care to delegate. But that's not an issue
for here, HBASE-11639 has already been reviewed and committed and this is a backport.


was (Author: apurtell):
I made a pass over this and it seems fine. Let me see about committing this today, it should
be in place ahead of HBASE-11764 because there's a small conflict with tag type allocation.
(I'll fix that in HBASE-11764). Will take a closer look then.

One higher level question I have about this whole design is what happens if we want to replicate
visibility tags as Strings over an existing custom ReplicationEndpoint? That won't be possible
today because an endpoint is implemented by a single class, there's no opportunity for mixing
in functionality. But that's not an issue for here, HBASE-11639 has already been reviewed
and committed and this is a backport.

> Backport HBASE-11639 (Replicate the visibility of Cells as strings) to 0.98
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-12619
>                 URL: https://issues.apache.org/jira/browse/HBASE-12619
>             Project: HBase
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.98.8
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>              Labels: visibility
>             Fix For: 0.98.9
>
>         Attachments: HBASE-11639_0.98_1.patch
>
>
> Raising a back port issue for HBASE-11639. We have the patch ready just need to see how
we are handling the new CP hook in RS Observer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message