hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12614) Potentially unclosed StoreFile(s) in DefaultCompactor#compact()
Date Wed, 03 Dec 2014 00:19:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232372#comment-14232372
] 

Elliott Clark commented on HBASE-12614:
---------------------------------------

Yeah [~lhofhansl] I think you are correct, since the list will only contain private readers
the change in behavior shouldn't affect anyone.

> Potentially unclosed StoreFile(s) in DefaultCompactor#compact()
> ---------------------------------------------------------------
>
>                 Key: HBASE-12614
>                 URL: https://issues.apache.org/jira/browse/HBASE-12614
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 12614-v1.txt, 12614-v2.txt
>
>
> Here is the related code (around line 129):
> {code}
>         for (StoreFile f : readersToClose) {
>           f.closeReader(true);
>         }
> {code}
> If any closeReader() call throws IOException, the remaining StoreFile(s) would not be
closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message