hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12612) WALFactory use in upgrade path must clean up properly
Date Tue, 02 Dec 2014 17:10:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231754#comment-14231754

Sean Busbey commented on HBASE-12612:

The test that caught htis in branch-1, TestNamespaceUpgrade, is no longer present in master.
Adding back in some version of that test to catch this problem going forward would be nice.

> WALFactory use in upgrade path must clean up properly
> -----------------------------------------------------
>                 Key: HBASE-12612
>                 URL: https://issues.apache.org/jira/browse/HBASE-12612
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Blocker
>             Fix For: 2.0.0
> The namespace upgrade code from pre-0.96 requires a clean shutdown prior to run. Right
now the NamespaceUpgrade code does the following
> # instantiate wal factory
> # ask for a meta-wal
> # online meta and make changes
> # clean up meta-wal
> That last bit is done instead of closing the factory itself. Since the factory initializes
a non-meta-wal as a part of its constructor, not closing it leaves behind an empty wal. The
rest of hte upgrade process sees that empty wal as an indicator that there's been a failure
and goes into recovery.
> The recovery process skips the loading of the hbase:acl table, which then causes the
upgrade after master initialization to fail.

This message was sent by Atlassian JIRA

View raw message