hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12566) HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)
Date Thu, 18 Dec 2014 20:13:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252171#comment-14252171
] 

James Taylor commented on HBASE-12566:
--------------------------------------

What does it mean if an interface is marked as @InterfaceAudience.Private? An example is RegionScanner
which is returned from the doPostScannerOpen RegionObserver coprocessors method. Phoenix uses
this interface to provide a different scanner that does aggregation from a coprocessor hook.
Is this forbidden as well?


> HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)
> -------------------------------------------------------------------
>
>                 Key: HBASE-12566
>                 URL: https://issues.apache.org/jira/browse/HBASE-12566
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>              Labels: Phoenix
>
> I've discovered after HBASE-12550 that Phoenix has a class that was broken by a change
to a package scoped method in HRegion:
> {code}
> diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/reg
> index 39a9fdc..3377e6b 100644
> --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> @@ -4628,11 +4628,12 @@ public class HRegion implements HeapSize { // , Writable{
>    /**
>     * Create a daughter region from given a temp directory with the region data.
>     * @param hri Spec. for daughter region to open.
> +   * @param expectedReferenceFileCount
>     * @throws IOException
>     */
> -  HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException {
> +  HRegion createDaughterRegionFromSplits(final HRegionInfo hri, int expectedReferenceFileCount)
throws IOException {
>      // Move the files from the temporary .splits to the final /table/region directory
> -    fs.commitDaughterRegion(hri);
> +    fs.commitDaughterRegion(hri, expectedReferenceFileCount);
> {code}
> We should change the HRegion InterfaceAudience to LimitedPrivate(COPROC, PHOENIX).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message