hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Srungarapu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12564) consolidate the getTableDescriptors() semantic
Date Mon, 01 Dec 2014 20:57:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230443#comment-14230443
] 

Srikanth Srungarapu commented on HBASE-12564:
---------------------------------------------

The patch looks good to me. Some minor concerns.
* IMO using if(req.getIncludeSysTables() || desc.getTableName().isSystemTable()) would be
more readable.
{code}
 if(!(!req.getIncludeSysTables() && desc.getTableName().isSystemTable())) {
{code}
* Replace hbase:acl using constants ?
{code}
+    // Verify that we can read sys-tables
+    assertEquals(1, SUPERUSER.runAs(getPrivilegedAction("hbase:acl")).size());
{code}
* How about one more assert statement with null value for regex so that HBASE-12301 will get
validated too?

> consolidate the getTableDescriptors() semantic
> ----------------------------------------------
>
>                 Key: HBASE-12564
>                 URL: https://issues.apache.org/jira/browse/HBASE-12564
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, master
>    Affects Versions: 2.0.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12564-v0.patch
>
>
> Master getTableDescriptors() which is called by Admin.listTables() has a couple of different
behaviors depending on how it is called. 
> after HBASE-12073 with the AccessController enabled, we now get a "global admin" required
if listTables() is called without a regex otherwise we return only the table that the user
can see (we show only the tables that the user have access to, which means or the user is
a global admin or it has a table-level create/admin). We probably should have the second behavior
even without regex, since I should able to see "my own tables". 
> getTableDescriptors() is returning only non system tables. Tools like user_permission
that are doing "for each listTable(): userPerm(table)" are losing the system tables, so stuff
like user_permission 'hbase:acls' will not result any result.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message