hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12559) Provide LoadBalancer with online configuration capability
Date Mon, 01 Dec 2014 18:34:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230201#comment-14230201

stack commented on HBASE-12559:

bq. HMaster extends HRegionServer. If one RPC method is defined, should master config be modified,
region server config be modified, or both ?

You make no distinction in your patch doing a blanket reload; the master+regionserver combined
daemon config is reread.

Why special case when all this work has been done to undo the master/regionserver distinction?

See head of ConfigurationManager. The way you update Balancer is not via the newly added ConfigurationObserver
mechanism but by a new method.

This patch could have been much smaller, just making the balancer a ConfigurationObserver.

> Provide LoadBalancer with online configuration capability
> ---------------------------------------------------------
>                 Key: HBASE-12559
>                 URL: https://issues.apache.org/jira/browse/HBASE-12559
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0
>         Attachments: 12559-v1.txt, 12559-v2.txt, 12559-v3.txt, 12559-v4.txt, 12559-v4.txt,
12559-v5.txt, 12559-v6.txt
> StochasticLoadBalancer has many knobs which user can adjust.
> It would increase productivity by allowing StochasticLoadBalancer to accept online configuration
> LoadBalancer already implements setConf(Configuration) method which reloads relevant
configuration parameters.
> We need to add updateMasterConfiguration() method to Admin which invokes the setConf()

This message was sent by Atlassian JIRA

View raw message