hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
Date Tue, 02 Dec 2014 19:52:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232046#comment-14232046
] 

stack commented on HBASE-12490:
-------------------------------

Applied addendum on branch-1 to fix failing TestAsyncProcess.testHTableFailedPutAndNewPut
https://builds.apache.org/job/HBase-1.0/528/testReport/

commit e424d4254efd8372cbf28b8c134fe2fec423639a
Author: stack <stack@apache.org>
Date:   Tue Dec 2 11:48:46 2014 -0800

    HBASE-12490 Replace uses of setAutoFlush(boolean, boolean) (Solomon Duskis) -- ADDENDUM
to fix failing TestAsyncProcess#testHTableFailedPutAndNewPut


> Replace uses of setAutoFlush(boolean, boolean)
> ----------------------------------------------
>
>                 Key: HBASE-12490
>                 URL: https://issues.apache.org/jira/browse/HBASE-12490
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 0.99.2
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch,
HBASE-12490C-branch-1.patch, HBASE-12490C.patch
>
>
> The various uses of setAutoFlush() seem to need some tlc.  There's a note in HTableInterface:
"@deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean)
instead."  It would be ideal to change all internal uses of setAutoFlush(boolean, boolean)
to use setAutoFlushTo, if possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places.  setAutoFlush(false,
false) has the same results as HTable.setAutoFlush(false).  Calling HTable.setAutoFlush(false,
true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false)
was not called previously (by default, the second parameter, clearBufferOnFail, is true and
should remain true according to the comments). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message