hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)
Date Tue, 02 Dec 2014 18:16:13 GMT

     [ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-12490:
--------------------------
       Resolution: Fixed
    Fix Version/s: 0.99.2
                   2.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

nvm my last comment. This patch only removes our internal use of the setAutoFlush(boolean,
boolean).  It does not remove the the actual APIs (they are deprecated).

We should be good now in branch-1 and master.  Resolving.  Thanks for the cleanup [~sduskis]

> Replace uses of setAutoFlush(boolean, boolean)
> ----------------------------------------------
>
>                 Key: HBASE-12490
>                 URL: https://issues.apache.org/jira/browse/HBASE-12490
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 0.99.2
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch,
HBASE-12490C-branch-1.patch, HBASE-12490C.patch
>
>
> The various uses of setAutoFlush() seem to need some tlc.  There's a note in HTableInterface:
"@deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean)
instead."  It would be ideal to change all internal uses of setAutoFlush(boolean, boolean)
to use setAutoFlushTo, if possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places.  setAutoFlush(false,
false) has the same results as HTable.setAutoFlush(false).  Calling HTable.setAutoFlush(false,
true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false)
was not called previously (by default, the second parameter, clearBufferOnFail, is true and
should remain true according to the comments). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message