hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12485) Maintain SeqId monotonically increasing
Date Thu, 04 Dec 2014 21:32:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234649#comment-14234649
] 

stack commented on HBASE-12485:
-------------------------------

Throw exception rather than WARN.
3547	            LOG.warn("Found decreasing SeqId. PreId=" + currentEditSeqId + " key=" +
key
3548	                + "; edit=" + val);
It will never happen, right? (smile)

I did not realize we were writing a file into region with the sequenceid.  Better than into
zk I'd say.  Should the special file instead be named with a dot prefix like other special
files (see head of HRegionFileSystem for list -- .regioninfo, .tmp, etc.)

> Maintain SeqId monotonically increasing
> ---------------------------------------
>
>                 Key: HBASE-12485
>                 URL: https://issues.apache.org/jira/browse/HBASE-12485
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: HBASE-12485.patch
>
>
> We added FLUSH, REGION CLOSE events into WAL, for each those events the region SeqId
is bumped. 
> The issue comes from region close operation. Because when opening a region, we use flushed
SeqId from store files while after store flush during region close we still write COMMIT_FLUSH,
REGION_CLOSE events etc which respectively bump up SeqId. Therefore, the region opening SeqId
is lower than it should be.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message