hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12012) Improve cancellation for the scan RPCs
Date Mon, 22 Dec 2014 22:45:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256276#comment-14256276
] 

stack commented on HBASE-12012:
-------------------------------

+1

Nice test.

Why we let out the controller here?

  public PayloadCarryingRpcController getController() {

Seems like something we'd want to keep internal.

There is still inconsistency as below:

82	      retryingCaller.cancel();
83	      if (future instanceof Cancellable) ((Cancellable)future).startCancel();

i.e. cancel and startCancel but reconciliation can be done in a follow-on.



> Improve cancellation for the scan RPCs
> --------------------------------------
>
>                 Key: HBASE-12012
>                 URL: https://issues.apache.org/jira/browse/HBASE-12012
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 12012-1.txt, 12012-2.txt, 12012-3.txt, 12012-4.txt, 12012-5.txt
>
>
> Similar to HBASE-11564 but for scans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message