hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12012) Improve cancellation for the scan RPCs
Date Thu, 18 Dec 2014 18:05:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251966#comment-14251966
] 

Nick Dimiduk commented on HBASE-12012:
--------------------------------------

{quote}
bq. Separate interface? Can we not push this feature down into all RetryingCallables?
This makes sense for the replica callables.. So it's done for those only.
{quote}

I suppose so. Proper interrupt handling in client RPC is something to address separately.

bq. I don't think we need to add synchronized here. Can you see a reason for this?

I was thinking another thread could access the instance, check it's {{isCanceled}}, take some
action even though the request hasn't actually be canceled yet. Other than defensive coding,
I don't have a specific problematic interaction in mind.

lgtm, +1

> Improve cancellation for the scan RPCs
> --------------------------------------
>
>                 Key: HBASE-12012
>                 URL: https://issues.apache.org/jira/browse/HBASE-12012
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 12012-1.txt, 12012-2.txt, 12012-3.txt
>
>
> Similar to HBASE-11564 but for scans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message