Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C1774101F5 for ; Wed, 19 Nov 2014 00:08:35 +0000 (UTC) Received: (qmail 61851 invoked by uid 500); 19 Nov 2014 00:08:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 61666 invoked by uid 500); 19 Nov 2014 00:08:35 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 61433 invoked by uid 99); 19 Nov 2014 00:08:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2014 00:08:35 +0000 Date: Wed, 19 Nov 2014 00:08:35 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12529) Use ThreadLocalRandom for RandomQueueBalancer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217094#comment-14217094 ] stack commented on HBASE-12529: ------------------------------- +1 Was going to go through our code base and see where we could use this java7 feature in place of expensive new Randoms. Thanks [~mbertozzi] > Use ThreadLocalRandom for RandomQueueBalancer > --------------------------------------------- > > Key: HBASE-12529 > URL: https://issues.apache.org/jira/browse/HBASE-12529 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC > Affects Versions: 2.0.0, 0.99.1, 0.98.6.1 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Priority: Minor > Fix For: 2.0.0, 0.98.9, 0.99.2 > > Attachments: HBASE-12529-v0.patch > > > looks like the Random in RandomQueueBalancer is now the main cause of contention in the rpc queue insertion. we should replace that Random with a ThreadLocalRandom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)