Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5B4910E39 for ; Mon, 17 Nov 2014 21:11:35 +0000 (UTC) Received: (qmail 73086 invoked by uid 500); 17 Nov 2014 21:11:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 73041 invoked by uid 500); 17 Nov 2014 21:11:35 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 73027 invoked by uid 99); 17 Nov 2014 21:11:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2014 21:11:35 +0000 Date: Mon, 17 Nov 2014 21:11:34 +0000 (UTC) From: "Virag Kothari (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12480) Regions in FAILED_OPEN/FAILED_CLOSE should be processed on master failover MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215181#comment-14215181 ] Virag Kothari commented on HBASE-12480: --------------------------------------- bq. If serverName is null, onlineServers should not contain it. Problem is onlineServers cannot do that contain check. Passing null to ConcurrentMap.keySet().contains() will throw NPE bq. In master branch, the server should be never null if it is in these states. TestAssignmentManagerOnCluster.testFailedOpen() asserts for null server in failed open state. Could we have a possible case on real cluster where we try to assign a region not in region states and end up in similar situation? bq. Should use invokeUnAssign. Hmm, will make the change. My initial thinking was that we need to make blocking calls but that doesn't seem to matter. > Regions in FAILED_OPEN/FAILED_CLOSE should be processed on master failover > --------------------------------------------------------------------------- > > Key: HBASE-12480 > URL: https://issues.apache.org/jira/browse/HBASE-12480 > Project: HBase > Issue Type: Bug > Components: Region Assignment > Reporter: Virag Kothari > Assignee: Virag Kothari > Fix For: 2.0.0, 0.98.9, 0.99.2 > > Attachments: HBASE-12480.patch > > > For zk assignment, we used to process this regions. For zk less assignment, we should do the same -- This message was sent by Atlassian JIRA (v6.3.4#6332)