Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C94C10148 for ; Mon, 10 Nov 2014 20:40:34 +0000 (UTC) Received: (qmail 61506 invoked by uid 500); 10 Nov 2014 20:40:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 61452 invoked by uid 500); 10 Nov 2014 20:40:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 61440 invoked by uid 99); 10 Nov 2014 20:40:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Nov 2014 20:40:33 +0000 Date: Mon, 10 Nov 2014 20:40:33 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12454) Setting didPerformCompaction early in HRegion#compact MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205296#comment-14205296 ] Andrew Purtell commented on HBASE-12454: ---------------------------------------- Is this right or am I missing something? > Setting didPerformCompaction early in HRegion#compact > ----------------------------------------------------- > > Key: HBASE-12454 > URL: https://issues.apache.org/jira/browse/HBASE-12454 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.8 > Reporter: Andrew Purtell > > It appears we are setting 'didPerformCompaction' to "true" before attempting the compaction in HRegion#compact. If Store#compact throws an exception or is interrupted, we won't call Store#cancelRequestedCompaction in the last finally block of the method as it looks like we should. > {code} > --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > @@ -1565,8 +1565,8 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver { // > doRegionCompactionPrep(); > try { > status.setStatus("Compacting store " + store); > - didPerformCompaction = true; > store.compact(compaction); > + didPerformCompaction = true; > } catch (InterruptedIOException iioe) { > String msg = "compaction interrupted"; > LOG.info(msg, iioe); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)