Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0925AC707 for ; Sat, 15 Nov 2014 16:34:39 +0000 (UTC) Received: (qmail 41663 invoked by uid 500); 15 Nov 2014 16:34:33 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 41613 invoked by uid 500); 15 Nov 2014 16:34:33 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 41600 invoked by uid 99); 15 Nov 2014 16:34:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Nov 2014 16:34:33 +0000 Date: Sat, 15 Nov 2014 16:34:33 +0000 (UTC) From: "Sean Busbey (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12437) HLogFactory should be able to accept multiple custom WALReaders in case of failure to read WAL logs due to upgrade/migrate of hbase MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213692#comment-14213692 ] Sean Busbey commented on HBASE-12437: ------------------------------------- Don't sequence files have a well defined magic number? does that magic number collide with what we write as a normal matter of course in the protobuf version? > HLogFactory should be able to accept multiple custom WALReaders in case of failure to read WAL logs due to upgrade/migrate of hbase > ----------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-12437 > URL: https://issues.apache.org/jira/browse/HBASE-12437 > Project: HBase > Issue Type: Bug > Components: wal > Affects Versions: 0.96.0, 0.98.4 > Reporter: Enoch Hsu > Assignee: Enoch Hsu > Fix For: 1.0.0, 0.98.4 > > Attachments: HBASE_12437.patch > > > The HLogFactory createReader function allows the user to create their own reader and just assumes that the reader will work correctly. > The default implementation checks between Protobuf and sequencefiles. However, the custom reader option does not account for any differences in the files. > There should be an option or configuration to specify multiple custom readers in the case that an old custom reader was used for sequence files and and a custom reader is being used for protobuf instead of throwing an IPBRE > The current HLogFactory does not allow me to fall back and handle upgraded file systems similar to the default case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)