Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5D84217CA1 for ; Thu, 6 Nov 2014 21:06:34 +0000 (UTC) Received: (qmail 74290 invoked by uid 500); 6 Nov 2014 21:06:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 74239 invoked by uid 500); 6 Nov 2014 21:06:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 74227 invoked by uid 99); 6 Nov 2014 21:06:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 21:06:34 +0000 Date: Thu, 6 Nov 2014 21:06:34 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12432) RpcRetryingCaller should log after fixed number of retries like AsyncProcess MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200927#comment-14200927 ] Andrew Purtell commented on HBASE-12432: ---------------------------------------- bq. Minor tweak to log only what the callable thinks is useful, not the whole exception. +1 on the second patch (01) bq. Shouldn't we should consolidate these into a single execution path? Sure let's look at it but after the change on this issue goes in. :-) > RpcRetryingCaller should log after fixed number of retries like AsyncProcess > ---------------------------------------------------------------------------- > > Key: HBASE-12432 > URL: https://issues.apache.org/jira/browse/HBASE-12432 > Project: HBase > Issue Type: Improvement > Components: Client > Reporter: Nick Dimiduk > Assignee: Nick Dimiduk > Priority: Minor > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: HBASE-12432.00-0.98.patch, HBASE-12432.00.patch, HBASE-12432.01-0.98.patch, HBASE-12432.01.patch > > > Scanner retry is handled by RpcRetryingCaller. This is different from multi, which is handled by AsyncProcess. AsyncProcess will start logging operation status after hbase.client.start.log.errors.counter retries have been attempted. Let's bring the same functionality over to Scanner path. > Noticed this while debugging IntegrationTestMTTR. -- This message was sent by Atlassian JIRA (v6.3.4#6332)