Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 14 Nov 2014 02:30:34 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12752120.1414799752000.496973.1415932234425@Atlassian.JIRA>
In-Reply-To: <JIRA.12752120.1414799752000@Atlassian.JIRA>
References: <JIRA.12752120.1414799752000@Atlassian.JIRA>
 <JIRA.12752120.1414799752439@arcas>
Subject: [jira] [Commented] (HBASE-12404) Task 5 from parent: Replace
 internal HTable constructor use with HConnection#getTable (0.98, 0.99)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-12404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211728#comment-14211728 ] 

Hadoop QA commented on HBASE-12404:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12681452/12404v6.txt
  against trunk revision .
  ATTACHMENT ID: 12681452

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 103 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    + * <a href="https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/InterfaceClassification.html">Hadoop
+{@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}, and
+{@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+   {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}
+   or {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call, org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+method's argument.  Calling {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class, byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestNamespace
                  org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod
                  org.apache.hadoop.hbase.master.handler.TestTableDescriptorModification
                  org.apache.hadoop.hbase.client.TestScannerTimeout
                  org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
                  org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
                  org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
                  org.apache.hadoop.hbase.regionserver.TestJoinedScanners
                  org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
                  org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook
                  org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil
                  org.apache.hadoop.hbase.master.TestMaster
                  org.apache.hadoop.hbase.regionserver.TestTags
                  org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions
                  org.apache.hadoop.hbase.quotas.TestQuotaAdmin
                  org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
                  org.apache.hadoop.hbase.client.TestFromClientSide
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.TestMultiVersions
                  org.apache.hadoop.hbase.client.TestTimestampsFilter
                  org.apache.hadoop.hbase.TestMetaTableAccessorNoCluster
                  org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
                  org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
                  org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
                  org.apache.hadoop.hbase.security.access.TestAccessController2
                  org.apache.hadoop.hbase.trace.TestHTraceHooks
                  org.apache.hadoop.hbase.master.TestRegionPlacement
                  org.apache.hadoop.hbase.regionserver.TestCompactionState
                  org.apache.hadoop.hbase.fs.TestBlockReorder
                  org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
                  org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  org.apache.hadoop.hbase.client.TestTableSnapshotScanner
                  org.apache.hadoop.hbase.util.TestHBaseFsck
                  org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
                  org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink
                  org.apache.hadoop.hbase.constraint.TestConstraint
                  org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
                  org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
                  org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
                  org.apache.hadoop.hbase.filter.TestColumnRangeFilter
                  org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove
                  org.apache.hadoop.hbase.mapreduce.TestCopyTable
                  org.apache.hadoop.hbase.util.TestMergeTable
                  org.apache.hadoop.hbase.master.TestMasterFailover
                  org.apache.hadoop.hbase.client.TestMultiParallel
                  org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
                  org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
                  org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
                  org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.TestZooKeeper
                  org.apache.hadoop.hbase.mapred.TestTableInputFormat
                  org.apache.hadoop.hbase.util.TestRegionSplitter
                  org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
                  org.apache.hadoop.hbase.client.TestCheckAndMutate
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths
                  org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
                  org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
                  org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload
                  org.apache.hadoop.hbase.filter.TestFilterWithScanLimits
                  org.apache.hadoop.hbase.security.access.TestAccessControlFilter
                  org.apache.hadoop.hbase.backup.TestHFileArchiving
                  org.apache.hadoop.hbase.client.TestFromClientSideNoCodec
                  org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator
                  org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
                  org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
                  org.apache.hadoop.hbase.client.TestHTableMultiplexer
                  org.apache.hadoop.hbase.regionserver.TestRegionReplicas
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
                  org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
                  org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
                  org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes
                  org.apache.hadoop.hbase.security.access.TestCellACLs
                  org.apache.hadoop.hbase.client.TestClientOperationInterrupt
                  org.apache.hadoop.hbase.quotas.TestQuotaTableUtil
                  org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout
                  org.apache.hadoop.hbase.mapreduce.TestImportExport
                  org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver
                  org.apache.hadoop.hbase.filter.TestScanRowPrefix
                  org.apache.hadoop.hbase.client.TestMultipleTimestamps
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2
                  org.apache.hadoop.hbase.util.TestHBaseFsckEncryption
                  org.apache.hadoop.hbase.coprocessor.TestClassLoading
                  org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
                  org.apache.hadoop.hbase.client.TestHCM
                  org.apache.hadoop.hbase.client.TestReplicaWithCluster
                  org.apache.hadoop.hbase.io.encoding.TestPrefixTree
                  org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler
                  org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
                  org.apache.hadoop.hbase.client.TestAdmin2
                  org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
                  org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
                  org.apache.hadoop.hbase.security.access.TestNamespaceCommands
                  org.apache.hadoop.hbase.mapreduce.TestCellCounter
                  org.apache.hadoop.hbase.master.TestRollingRestart
                  org.apache.hadoop.hbase.mapreduce.TestWALPlayer
                  org.apache.hadoop.hbase.mapreduce.TestHRegionPartitioner
                  org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort
                  org.apache.hadoop.hbase.filter.TestFilterWrapper
                  org.apache.hadoop.hbase.client.TestSnapshotMetadata
                  org.apache.hadoop.hbase.snapshot.TestExportSnapshot
                  org.apache.hadoop.hbase.TestAcidGuarantees
                  org.apache.hadoop.hbase.TestHBaseTestingUtility
                  org.apache.hadoop.hbase.regionserver.wal.TestHLogFiltering
                  org.apache.hadoop.hbase.client.TestPutWithDelete
                  org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
                  org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
                  org.apache.hadoop.hbase.TestFullLogReconstruction
                  org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
                  org.apache.hadoop.hbase.TestInfoServers
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
                  org.apache.hadoop.hbase.replication.TestPerTableCFReplication
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack
                  org.apache.hadoop.hbase.regionserver.TestRegionServerOnlineConfigChange
                  org.apache.hadoop.hbase.client.TestReplicasClient
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.client.TestFastFail
                  org.apache.hadoop.hbase.master.TestDistributedLogSplitting
                  org.apache.hadoop.hbase.replication.TestReplicationWithTags
                  org.apache.hadoop.hbase.client.TestRpcControllerFactory
                  org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
                  org.apache.hadoop.hbase.regionserver.TestHRegion
                  org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster
                  org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
                  org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.mapreduce.TestRowCounter
                  org.apache.hadoop.hbase.master.TestRestartCluster
                  org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy
                  org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas
                  org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes
                  org.apache.hadoop.hbase.replication.TestReplicationEndpoint
                  org.apache.hadoop.hbase.master.TestTableLockManager
                  org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient
                  org.apache.hadoop.hbase.security.access.TestScanEarlyTermination
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
                  org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat
                  org.apache.hadoop.hbase.master.TestMasterTransitions
                  org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
                  org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache
                  org.apache.hadoop.hbase.replication.TestReplicationSmallTests
                  org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
                  org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat
                  org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
                  org.apache.hadoop.hbase.client.TestScannersFromClientSide
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay
                  org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
                  org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
                  org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas
                  org.apache.hadoop.hbase.client.TestMetaScanner
                  org.apache.hadoop.hbase.TestMetaTableAccessor
                  org.apache.hadoop.hbase.client.TestFromClientSide3
                  org.apache.hadoop.hbase.master.TestAssignmentListener
                  org.apache.hadoop.hbase.quotas.TestQuotaThrottle
                  org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay
                  org.apache.hadoop.hbase.TestIOFencing
                  org.apache.hadoop.hbase.master.handler.TestCreateTableHandler
                  org.apache.hadoop.hbase.regionserver.TestSCVFWithMiniCluster
                  org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed
                  org.apache.hadoop.hbase.security.access.TestTablePermissions
                  org.apache.hadoop.hbase.regionserver.TestEncryptionRandomKeying
                  org.apache.hadoop.hbase.client.TestAdmin1
                  org.apache.hadoop.hbase.replication.TestMasterReplication
                  org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
                  org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap

     {color:red}-1 core zombie tests{color}.  There are 11 zombie test(s): 	at org.apache.hadoop.hbase.client.TestAdmin2.testReadOnlyTable(TestAdmin2.java:217)
	at org.apache.hadoop.hbase.TestZooKeeper.testSanity(TestZooKeeper.java:258)
	at org.apache.hadoop.hbase.TestZooKeeper.testMasterSessionExpired(TestZooKeeper.java:227)
	at org.apache.hadoop.hbase.master.TestMasterNoCluster.testNotPullingDeadRegionServerFromZK(TestMasterNoCluster.java:306)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11669//console

This message is automatically generated.

> Task 5 from parent: Replace internal HTable constructor use with HConnection#getTable (0.98, 0.99)
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12404
>                 URL: https://issues.apache.org/jira/browse/HBASE-12404
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.99.2
>
>         Attachments: 0001-HBASE-12404-Task-5-from-parent-Replace-internal-HTab.patch, 12404.txt, 12404v2.txt, 12404v3.txt, 12404v5.txt, 12404v6.txt
>
>
> Do the step 5. from the [~ndimiduk] list in parent issue.  Go through src code and change all new HTable to instead be connection.getTable.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)