hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12598) Replace uses of setAutoFlush(boolean, boolean) in 0.99.2
Date Sat, 29 Nov 2014 17:57:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228868#comment-14228868

stack commented on HBASE-12598:

Where in the patch do we do something other than what was there previous [~sduskis]?  

As I understand it, this gets us the behavior we had before the patch:

	      table.setAutoFlush(false, true);	185	      table.setAutoFlushTo(false);

This is only combination that changes behavior:

741	    ht.setAutoFlush(false, false);	741	    ht.setAutoFlush(false);

... but it is deprecated setting clearBufferOnFail going forward.

So apply this patch to branch-1 and what is in HBASE-12490 to master branch?  (Is there extra
stuff in your patch? These things '����', for spaces?)

> Replace uses of setAutoFlush(boolean, boolean) in 0.99.2
> --------------------------------------------------------
>                 Key: HBASE-12598
>                 URL: https://issues.apache.org/jira/browse/HBASE-12598
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.99.2
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>         Attachments: HBASE-12598B.patch
> HBASE-12490 changed the 2.0.0 branch.  This is a similar change to branch-1.
> The various uses of setAutoFlush() seem to need some tlc. There's a note in HTableInterface:
"@deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean)
instead." It would be ideal to change all internal uses of setAutoFlush(boolean, boolean)
to use setAutoFlushTo, if possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places. setAutoFlush(false,
false) has the same results as HTable.setAutoFlush(false). Calling HTable.setAutoFlush(false,
true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false)
was not called previously (by default, the second parameter, clearBufferOnFail, is true and
should remain true according to the comments).

This message was sent by Atlassian JIRA

View raw message