hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12569) Control MaxDirectMemorySize in the same manner as heap size
Date Tue, 25 Nov 2014 03:39:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223999#comment-14223999
] 

Hadoop QA commented on HBASE-12569:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12683458/0001-HBASE-12569-Update-scripts-to-control-MaxDirectMemor.patch
  against master branch at commit e83082a88816684714d8a563967046e582f9b8c7.
  ATTACHMENT ID: 12683458

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +  exec "$JAVA" -Dproc_$COMMAND -XX:OnOutOfMemoryError="kill -9 %p" $HEAP_SETTINGS $HBASE_OPTS
$CLASS "$@"
+set java_arguments=%HEAP_SETTINGS% %HBASE_OPTS% -classpath "%CLASSPATH%" %CLASS% %hbase-command-arguments%
+                  <varname>HBASE_OFFHEAPSIZE</varname> to a value greater than
the offheap size wanted, in

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileGetting(TestHRegion.java:3843)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11818//console

This message is automatically generated.

> Control MaxDirectMemorySize in the same manner as heap size
> -----------------------------------------------------------
>
>                 Key: HBASE-12569
>                 URL: https://issues.apache.org/jira/browse/HBASE-12569
>             Project: HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.98.7
>         Environment: CentOS 6
>            Reporter: Patrick White
>            Assignee: Patrick White
>            Priority: Minor
>             Fix For: 2.0.0, 0.98.9, 0.99.2
>
>         Attachments: 0001-HBASE-12569-Update-scripts-to-control-MaxDirectMemor.patch
>
>
> It would make it much easier on us if we could manage MaxDirectMemorySize in the same
way as heap. This patch allows that to happen.
> Note: I have not tested the *.cmd modifications as I don't have a Windows box (at the
moment, can test at home) but look like they should work (famous last words).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message