hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12527) Remove padding around parens
Date Sat, 29 Nov 2014 18:15:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228878#comment-14228878
] 

Hadoop QA commented on HBASE-12527:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12684254/HBASE-12527.patch
  against master branch at commit 58b6b24c2999511daefa0dff2e2ae745cba24e35.
  ATTACHMENT ID: 12684254

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 224 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +   *             {@link #ReversedScannerCallable(ClusterConnection, TableName, Scan,
ScanMetrics, byte[], RpcControllerFactory)}
+   * Override this method, if you want to bulk exclude regions altogether from M-R. By default,
no region is excluded(i.e. all regions are included).
+      assertTrue(e.getMessage().contains("Problem in starting http server. Server handlers
failed"));

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11868//console

This message is automatically generated.

> Remove padding around parens
> ----------------------------
>
>                 Key: HBASE-12527
>                 URL: https://issues.apache.org/jira/browse/HBASE-12527
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sean Busbey
>            Assignee: Varun Saxena
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
and that matches [our ref guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message