hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12525) Wrap lines longer than 100 chars
Date Thu, 20 Nov 2014 14:44:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219435#comment-14219435

Sean Busbey commented on HBASE-12525:

bq. My concern is that there are so many warnings from checkstyle

we can do the same thing we have for javadoc now, where we set the current number of errors
and we show only the diff in the result. You want enforce that the new stuff is correct. (it
is almost the same thing as the deprecated api.. you enforce the new way, but you keep the
old bad stuff to avoid breaking everyone who can't migrate)

We do this now. However the numbers involved are in the multiple-thousands and "what's 2 more
when there are 2500?"

Also this doesn't help for when the contributor wants to know what they've added. For the
javadoc it's pretty easy to just run through the javadoc goal because the baseline is 2 expected
javadoc warnings.

bq. Would your concern be mitigated if I also brought the fix back to branch-1? earlier branches?

assuming that everyone can rebase up to this patch... yes it will help. but if you are stuck
in an old branch and you want to backport stuff this is just extra work and it will be increasingly
painful as more as you differ from the original branch.

Just to make sure I'm clear, this is specifically a concern for people maintaining forks outside
of the project repo?

> Wrap lines longer than 100 chars
> --------------------------------
>                 Key: HBASE-12525
>                 URL: https://issues.apache.org/jira/browse/HBASE-12525
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>              Labels: checkstyle
> After broadening the acceptable long lines in HBASE-12523, we still end up with ~900
cases of lines over our chosen length.
> Go through and wrap all of those that are sensible to wrap and then update HBASE-12523
with a list of additional exclusions.

This message was sent by Atlassian JIRA

View raw message