hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12525) Wrap lines longer than 100 chars
Date Thu, 20 Nov 2014 13:40:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219376#comment-14219376
] 

Sean Busbey commented on HBASE-12525:
-------------------------------------

My concern is that there are so many warnings from checkstyle that

  * There's too much noise for a new contributor to check what their changes introduce
  * (as a lesser concern) we realistically won't be able to go into enforcing mode for several
years, if at all

Would your concern be mitigated if I also brought the fix back to branch-1? earlier branches?

> Wrap lines longer than 100 chars
> --------------------------------
>
>                 Key: HBASE-12525
>                 URL: https://issues.apache.org/jira/browse/HBASE-12525
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>              Labels: checkstyle
>
> After broadening the acceptable long lines in HBASE-12523, we still end up with ~900
cases of lines over our chosen length.
> Go through and wrap all of those that are sensible to wrap and then update HBASE-12523
with a list of additional exclusions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message