hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12522) Backport WAL refactoring to branch-1
Date Sat, 22 Nov 2014 04:10:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221797#comment-14221797

Sean Busbey commented on HBASE-12522:

Sorry, missed this part in my original response.

I had a bit hard time understanding the WalProvider vs WalFactory though.

Providers are implementations around a particular kind of WAL. They're the interface a new
implementation would use to provide all the integration points we currently think we need.

Factory is just the entry point in the rest of the code base interacting with the wal code.
It's mostly a matter of abstracting away the instantiation and management of Providers. That
management could have been done with static methods if we had made WALProvider an abstract
class instead of an interface, but historically I've found it harder to properly handle testing
when there's a bunch of logic tied up in shared static state.

I think some of this distinction is obscured by not having yet taken care of the replay side
and the resultant reaching into the DefaultWALProvider.

> Backport WAL refactoring to branch-1
> ------------------------------------
>                 Key: HBASE-12522
>                 URL: https://issues.apache.org/jira/browse/HBASE-12522
>             Project: HBase
>          Issue Type: Task
>          Components: wal
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>             Fix For: 0.99.2
> backport HBASE-10378 to branch-1.
> This will let us remove the Deprecated stuff in master, allow some baking time within
the 1.x line, and will give us the option of pulling back follow on performance improvements.

This message was sent by Atlassian JIRA

View raw message