hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12522) Backport WAL refactoring to branch-1
Date Sat, 22 Nov 2014 02:05:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221744#comment-14221744
] 

Enis Soztutar commented on HBASE-12522:
---------------------------------------

I've reviewed the the patch for branch-1. It will be good to backport this. I had a bit hard
time understanding the WalProvider vs WalFactory though. 

I've noticed that you are using yoda conditionals which is not the practice in hbase. We do
not have to fix that for this patch, but it is good to be consistent throughout the code base.

{code}
if (null == providerId) {
{code}
Is this a typo? 
{code}
+  public void postSync(final long timeInNanos, final int handlerSyncs) {
+    source.incrementSyncTime(timeInNanos/1000000l);
   }
{code}

> Backport WAL refactoring to branch-1
> ------------------------------------
>
>                 Key: HBASE-12522
>                 URL: https://issues.apache.org/jira/browse/HBASE-12522
>             Project: HBase
>          Issue Type: Task
>          Components: wal
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>             Fix For: 0.99.2
>
>
> backport HBASE-10378 to branch-1.
> This will let us remove the Deprecated stuff in master, allow some baking time within
the 1.x line, and will give us the option of pulling back follow on performance improvements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message