hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12478) HBASE-10141 and MIN_VERSIONS are not compatible
Date Fri, 14 Nov 2014 23:52:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213093#comment-14213093
] 

Hadoop QA commented on HBASE-12478:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12681655/12478-0.98.patch
  against trunk revision .
  ATTACHMENT ID: 12681655

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11683//console

This message is automatically generated.

> HBASE-10141 and MIN_VERSIONS are not compatible
> -----------------------------------------------
>
>                 Key: HBASE-12478
>                 URL: https://issues.apache.org/jira/browse/HBASE-12478
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 12478-0.98.patch, 12478-v1.txt, 12478-v2.txt
>
>
> HBASE-10141 is a good optimization, eliminating the need to scan already expired files
(through TTL). However, I think if MIN_VERSIONS is set, it will not ensure that there will
be at least that many versions since it bypasses the scan layer. 
> I think we can just do a simple check before the HBASE-10141 optimization to see whether
MIN_VERSIONS is set for the table, and if so just do the regular old way of doing the scan
in the compaction. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message