hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-12471) Task 4. replace internal ConnectionManager#{delete,get}Connection use with #close, #createConnection (0.98, 0.99)
Date Mon, 17 Nov 2014 05:56:34 GMT

     [ https://issues.apache.org/jira/browse/HBASE-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-12471:
--------------------------
    Attachment: 12471v9.txt

Small amount of change. Replace ConnectionManager with ConnectionFactory
when getting a connection and do cleanup when done EXCEPT in HBaseAdmin
and in HTable constructors. I did not replace the three places we get a
connection in these classes because tests  rely on connections being
managed -- especially around Connections that have mocking -- and I'd
guess a few user applications similarly depend on the old behavior. So
I left these few places and changed all other locations under src/main/java (not
under test -- too big a job). Also moved a few places off
deprecated HConnection and on to the super Interface
ClusterConnection. Ditto for Connection and using Admin and Table
instead of HBaseAdmin and HTable.

Async.java
 Just renamings

HBaseAdmin.java
 Removed unused method.  Shutdown access on checkHBaseAvailable.

ZKConfig.java
 Tracing, HBase Configurations were not being copied over. What was
 there was a little silly, using clone to make us multi-thread safe...
 just do the synchronize the internal clone was doing.


> Task 4. replace internal ConnectionManager#{delete,get}Connection use with #close, #createConnection
(0.98, 0.99)
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12471
>                 URL: https://issues.apache.org/jira/browse/HBASE-12471
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: 0001-HBASE-12471-Task-4.-replace-internal-ConnectionManag.patch,
124471v4.txt, 12471v2.txt, 12471v3.txt, 12471v6.txt, 12471v7.txt, 12471v9.txt
>
>
> Let me do this. A bunch of this was done in HBASE-12404 Let me see if can find more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message