hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhaoyunjiong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12444) Total number of requests overflow because it's int
Date Wed, 12 Nov 2014 01:58:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207522#comment-14207522
] 

zhaoyunjiong commented on HBASE-12444:
--------------------------------------

I think we can safely change it according to "Updating A Message Type" in https://developers.google.com/protocol-buffers/docs/proto
{quote}
int32, uint32, int64, uint64, and bool are all compatible – this means you can change a
field from one of these types to another without breaking forwards- or backwards-compatibility.
If a number is parsed from the wire which doesn't fit in the corresponding type, you will
get the same effect as if you had cast the number to that type in C++ (e.g. if a 64-bit number
is read as an int32, it will be truncated to 32 bits).
{quote}

> Total number of requests overflow because it's int
> --------------------------------------------------
>
>                 Key: HBASE-12444
>                 URL: https://issues.apache.org/jira/browse/HBASE-12444
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck, master, regionserver
>            Reporter: zhaoyunjiong
>            Priority: Minor
>         Attachments: hbase-12444-v1.patch, hbase-12444.patch
>
>
> When running hbck, I noticed "Number of requests" was wrong:
> Average load: 466.41237113402065
> Number of requests: -1835941345
> Number of regions: 45242
> Number of regions in transition: 0
> The root cause is it use int, and clearly it overflowed.
> I'll update a patch later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message