hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enoch Hsu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-12437) HLogFactory does not allow fall back of custom WALReader in case of failure to read WAL logs due to upgrade/migrate of hbase
Date Thu, 06 Nov 2014 23:42:36 GMT

     [ https://issues.apache.org/jira/browse/HBASE-12437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Enoch Hsu updated HBASE-12437:
------------------------------
    Description: 
The HLogFactory createReader function allows the user to create their own reader and just
assumes that the reader will work correctly. 
The default implementation checks between Protobuf and sequencefiles. However, the custom
reader option does not account for any differences in the files. In the case that I used an
old custom reader for sequence files and now am using a custom reader for protobuf there should
be an option for hbase to choose which reader to use based on the file.

There should be an option or configuration to specify multiple custom readers in the case
that an old custom reader was used for sequence files and and a custom reader is being used
for protobuf instead of throwing an IPBRE
The current HLogFactory does not allow me to fall back and handle upgraded file systems similar
to the default case.

  was:
The HLogFactory createReader function allows the user to create their own reader and just
assumes that the reader will work correctly.
In the case the user accidentally uses an incorrect reader and gets an InvalidProtocolBufferReaderException,
HBase should have a safeguard to still allow HBase functions to execute.
I propose that in this case HBase should default to the standard HBase readers.(ProtobufLogReader
or  SequenceFIleLogReader)


> HLogFactory does not allow fall back of custom WALReader in case of failure to read WAL
logs due to upgrade/migrate of hbase
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12437
>                 URL: https://issues.apache.org/jira/browse/HBASE-12437
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.96.0, 0.98.4
>            Reporter: Enoch Hsu
>            Assignee: Enoch Hsu
>             Fix For: 1.0.0, 0.98.4
>
>         Attachments: HBASE_12437.patch
>
>
> The HLogFactory createReader function allows the user to create their own reader and
just assumes that the reader will work correctly. 
> The default implementation checks between Protobuf and sequencefiles. However, the custom
reader option does not account for any differences in the files. In the case that I used an
old custom reader for sequence files and now am using a custom reader for protobuf there should
be an option for hbase to choose which reader to use based on the file.
> There should be an option or configuration to specify multiple custom readers in the
case that an old custom reader was used for sequence files and and a custom reader is being
used for protobuf instead of throwing an IPBRE
> The current HLogFactory does not allow me to fall back and handle upgraded file systems
similar to the default case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message