hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-12424) Finer grained logging and metrics for split transactions
Date Thu, 06 Nov 2014 23:04:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201149#comment-14201149
] 

Andrew Purtell edited comment on HBASE-12424 at 11/6/14 11:03 PM:
------------------------------------------------------------------

I looked at the checkstyle warnings this patch introduces in SplitTransaction:
{quote}
 Error	design	VisibilityModifier	Variable 'type' must be private and have accessor methods.
165
 Error	design	VisibilityModifier	Variable 'timestamp' must be private and have accessor methods.
166
{quote}
We don't need field hiding and accessor methods for the journal entry type, it's a nested
type at default scope meant to be used in a struct-like manner. I have no plans to change
this


was (Author: apurtell):
I looked at the checkstyle warnings this patch introduces:
{quote}
 Error	design	VisibilityModifier	Variable 'type' must be private and have accessor methods.
165
 Error	design	VisibilityModifier	Variable 'timestamp' must be private and have accessor methods.
166
{quote}
We don't need field hiding and accessor methods for the journal entry type, it's a nested
type at default scope meant to be used in a struct-like manner. I have no plans to change
this

> Finer grained logging and metrics for split transactions
> --------------------------------------------------------
>
>                 Key: HBASE-12424
>                 URL: https://issues.apache.org/jira/browse/HBASE-12424
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 0001-HBASE-12424-Finer-grained-logging-and-metrics-for-sp.patch,
0002-HBASE-12424-Finer-grained-logging-and-metrics-for-sp.patch, 0003-HBASE-12424-Finer-grained-logging-and-metrics-for-sp.patch,
HBASE-12424.patch, HBASE-12424.patch, HowHBaseRegionSplitsareImplemented.pdf
>
>
> A split transaction is a complex orchestration of activity between the RegionServer,
Master, ZooKeeper, and HDFS NameNode. We have some visibility into the time taken by various
phases of the split transaction in the logs. We will see "Starting split of region $PARENT"
before the transaction begins, before the parent is offlined. Later we will see "Opening $DAUGHTER"
as one of the last steps in the transaction, this is after the parent has been flushed, offlined,
and closed. Finally ""Region split, hbase:meta updated, and report to master ... Split took
$TIME" after all steps are complete and including the total running time of the transaction.

> For debugging the cause(s) of long running split transactions it would be useful to know
the distribution of time spent in all of the phases of the split transaction. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message