hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12272) Generate Thrift code through maven
Date Thu, 06 Nov 2014 14:16:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200193#comment-14200193
] 

Sean Busbey commented on HBASE-12272:
-------------------------------------

Overall looks good, I ran through generation and things look correct.

minor bits that should be fixed before push:

{code}
+    <!--
+      Profile for regenerating the thrift java classes.
+      The generated files are to be committed to version control.
+      Activate using:
+       mvn compile -Dcompile-thrift
+    -->
{code}

should be {{mvn compile -Pcompile-thrift}}

{code}
-<p><i>Important note:</i> We tried to deprecate this Thrift interface and
replace it
+<h2><a name="importantnote">Important note</a></h2>
{code}

Leave out the named anchor if we're not using it.

{code}
-         </dependencies>   
+         </dependencies>
{code}

{code}
-           <systemPropertyVariables>
+            <systemPropertyVariables>
{code}

Leave out unrelated formatting fixes.


> Generate Thrift code through maven
> ----------------------------------
>
>                 Key: HBASE-12272
>                 URL: https://issues.apache.org/jira/browse/HBASE-12272
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, documentation, Thrift
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>             Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
>
>         Attachments: HBASE-12272-2014-10-15-v1-PREVIEW.patch, HBASE-12272-2014-10-16-v2.patch,
HBASE-12272-2014-10-16-v3.patch, HBASE-12272-2014-10-16-v4.patch, HBASE-12272-2014-11-04-v5.patch,
HBASE-12272-2014-11-05-v5.patch, HBASE-12272-2014-11-05-v5.patch
>
>
> The generated thrift code is currently under source control, but the instructions on
rebuilding it is buried in package javadocs.
> We should have a simple maven command to rebuild them, similar to what we have for protobufs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message