hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10671) Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client modules
Date Fri, 21 Nov 2014 03:09:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220447#comment-14220447
] 

Enis Soztutar commented on HBASE-10671:
---------------------------------------

bq. What is reasoning that has RetriesExhaustedException private yet RowTooBigException public?
Ditto QuotaExceededException and ThrottlingException
Yeah exceptions are hard. I though some clients maybe catching those exceptions, so we cannot
rename them for example. But I am not sure what exceptions should be catchable, and what others
are not. let me make these Public, since it seems even the base HBaseIOException is Public.


bq. In PreemptiveFastFailException you add imports but do not mark the class?
For PreemptiveFastFailException and some others, the annotation was there, but it was using
the hadoop package, not the hbase package. 
bq. Base64 is private because? Its general utility? You thinking folks should go elsewhere
for this kinda thing? Or you want to remove it (Do we use it anywhere other than in tooling?)
I though that it is only used internally. But if useful to clients, it should be ok to do
Public. The new patch changes that. 


> Add missing InterfaceAudience annotations for classes in hbase-common and hbase-client
modules
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10671
>                 URL: https://issues.apache.org/jira/browse/HBASE-10671
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: hbase-10671_v1.patch, hbase-10671_v2.patch, hbase-10671_v3.patch
>
>
> In this jira, we'll add missing InterfaceAudience annotations to classes in the client
visible modules (hbase-client and hbase-common).
> Parent jira is for deciding on whether some of the classes should be private or public.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message