hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singhi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8572) Enhance delete_snapshot.rb to call snapshot deletion API with regex
Date Thu, 06 Nov 2014 05:59:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199847#comment-14199847
] 

Ashish Singhi commented on HBASE-8572:
--------------------------------------

Thanks Matteo for more reviews.

bq. I tried with acl, and there the behaviour is a bit strange in my opinion, but is the same
on drop_all.
Yes, I checked this after your comment. Even disable_all and enable_all has the same behaviour
I digged into this to find out the cause. I think the problem comes with {{HBaseAdmin#listTables(String
regex)}} as to execute this api one needs global permission and this api is been called first
when we execute disable_all, enable_all and drop_all and hence it gets failed. 
I then checked from shell {{list 't.*'}} it works without any exception when checked the script
it calls the deprecated method {{HBaseAdmin#getTableNames(String regex)}}.
Can we raise a new Jira to handle this ?
And coming to snapshot, all the snapshot operations except list_snapshot requires global permission
as discussed here HBASE-7367.

{quote}
for snapshots there is also another extra case, where you may be able to remove just a subset
of the list (see HBASE-11869 Support snapshot owner) which means that you say Y and at the
first deleteSnapshot failure the operation is aborted.
{quote}
If I am understanding correctly this means we should not abort immediately seeing a failure,
rather try the operation on all the requested snapshot and then log it to the client. Can
we raise another jira to handle this, as it wil require some testing after HBASE-11869 gets
merged in the code ?

{quote}
also I think that will be useful to print the snapshot information instead of just the name,
at list you can spot if there is something named wrongly.
{quote}
This I will address in the next patch. Thanks for this. 

> Enhance delete_snapshot.rb to call snapshot deletion API with regex
> -------------------------------------------------------------------
>
>                 Key: HBASE-8572
>                 URL: https://issues.apache.org/jira/browse/HBASE-8572
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0, 0.98.8, 0.99.3
>
>         Attachments: HBASE-8572-v2.patch, HBASE-8572-v3.patch, HBASE-8572.patch
>
>
> HBASE-8461 added the API to HBaseAdmin which allows user to specify regular expression
for deleting snapshots.
> This JIRA would allow delete_snapshot.rb to utilize this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message