hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singhi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8572) Enhance delete_snapshot.rb to call snapshot deletion API with regex
Date Tue, 04 Nov 2014 14:27:35 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196145#comment-14196145
] 

Ashish Singhi commented on HBASE-8572:
--------------------------------------

Thanks Matteo for looking into this.

{quote}
so if someone had a script that was calling delete_snapshot after this patch the script will
no longer work because it requires an "y" even if the full name is specified (no regex just
the name)?
{quote}
Yes, after looking at the comment here
https://issues.apache.org/jira/browse/HBASE-8461?focusedCommentId=13661073&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13661073
which seems legit. So I developed in that way.

bq. drop table has two version "drop tablename" and "drop_all regex" maybe we should follow
the same pattern

I thought for it, but description said to enhance delete_snapshot. So I went ahead with that.

I will write a new script called delete_all_snapshot. Is this ok ?

> Enhance delete_snapshot.rb to call snapshot deletion API with regex
> -------------------------------------------------------------------
>
>                 Key: HBASE-8572
>                 URL: https://issues.apache.org/jira/browse/HBASE-8572
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ashish Singhi
>         Attachments: HBASE-8572.patch
>
>
> HBASE-8461 added the API to HBaseAdmin which allows user to specify regular expression
for deleting snapshots.
> This JIRA would allow delete_snapshot.rb to utilize this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message