Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D8867101CF for ; Fri, 24 Oct 2014 02:37:34 +0000 (UTC) Received: (qmail 98188 invoked by uid 500); 24 Oct 2014 02:37:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 98126 invoked by uid 500); 24 Oct 2014 02:37:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 98114 invoked by uid 99); 24 Oct 2014 02:37:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Oct 2014 02:37:34 +0000 Date: Fri, 24 Oct 2014 02:37:34 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12328) Need to separate JvmMetrics for Master and RegionServer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182340#comment-14182340 ] Hadoop QA commented on HBASE-12328: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12676799/HBASE-12328.2.patch against trunk revision . ATTACHMENT ID: 12676799 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/patchReleaseAuditWarnings.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11457//console This message is automatically generated. > Need to separate JvmMetrics for Master and RegionServer > ------------------------------------------------------- > > Key: HBASE-12328 > URL: https://issues.apache.org/jira/browse/HBASE-12328 > Project: HBase > Issue Type: Improvement > Reporter: Sanghyun Yun > Priority: Minor > Attachments: HBASE-12328.2.patch, HBASE-12328.patch > > > tag.ProcessName of JvmMetrics is "IPC". > It is same both Master and RegionServer. > {code:title=HBase(Master and RegionServer)'s Metrics Dump} > ... > "name": "Hadoop:service=HBase,name=JvmMetrics", > "modelerType": "JvmMetrics", > "tag.Context": "jvm", > "tag.ProcessName": "IPC", > "tag.SessionId": "", > ... > {code} > When I use HBase with Ganglia, > I wrote tagsForPrefix.jvm=ProcessName in hadoop-metrics2-hbase.properties. > {code:title=hadoop-metrics2-hbase.properties} > ... > *.sink.ganglia.class=org.apache.hadoop.metrics2.sink.ganglia.GangliaSink31 > hbase.sink.ganglia.tagsForPrefix.jvm=ProcessName > ... > {code} > But, Ganglia generate only one RRD file because tag.ProcessName is "IPC" both Master and Regionserver. > I think it need to separate JvmMetrics for Master and RegionServer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)