Return-Path: 
 <issues-return-167793-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2D3EB1742D
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue, 21 Oct 2014 03:41:34 +0000 (UTC)
Received: (qmail 98874 invoked by uid 500); 21 Oct 2014 03:41:34 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 98825 invoked by uid 500); 21 Oct 2014 03:41:34 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 98812 invoked by uid 99); 21 Oct 2014 03:41:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Oct 2014 03:41:34 +0000
Date: Tue, 21 Oct 2014 03:41:33 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12748188.1413334717000.302563.1413862893946@Atlassian.JIRA>
In-Reply-To: <JIRA.12748188.1413334717000@Atlassian.JIRA>
References: <JIRA.12748188.1413334717000@Atlassian.JIRA>
 <JIRA.12748188.1413334717117@arcas>
Subject: [jira] [Commented] (HBASE-12261) Add checkstyle to HBase build
 process
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177891#comment-14177891 ] 

Lars Hofhansl commented on HBASE-12261:
---------------------------------------

{{mvn test -Dtest=<test>}} is also broken (even after HBASE-12294):
{code}
HBase - Checkstyle ................................ FAILURE [0.477s]
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project hbase-checkstyle: No tests were executed!  (Set -DfailIfNoTests=false to ignore this error.) -> [Help 1]
{code}

Meh... Maven is so obtuse.
Maybe it's best to roll this back for now?

> Add checkstyle to HBase build process
> -------------------------------------
>
>                 Key: HBASE-12261
>                 URL: https://issues.apache.org/jira/browse/HBASE-12261
>             Project: HBase
>          Issue Type: Bug
>          Components: build, site
>    Affects Versions: 2.0.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 0.98.8, 0.99.2
>
>         Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
>
>
> We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches.
> Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)