Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0E65175B9 for ; Mon, 20 Oct 2014 21:23:36 +0000 (UTC) Received: (qmail 89171 invoked by uid 500); 20 Oct 2014 21:23:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 89081 invoked by uid 500); 20 Oct 2014 21:23:35 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88912 invoked by uid 99); 20 Oct 2014 21:23:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 21:23:35 +0000 Date: Mon, 20 Oct 2014 21:23:35 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177494#comment-14177494 ] Lars Hofhansl commented on HBASE-12261: --------------------------------------- Looks this broke assembly:single and install {{mvn -DskipTests install assembly:single}} is what I used to use to build a tarball, now it fails with this: {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.2-beta-5:single (default-cli) on project hbase-checkstyle: Error reading assemblies: No assembly descriptors found. -> [Help 1] {code} > Add checkstyle to HBase build process > ------------------------------------- > > Key: HBASE-12261 > URL: https://issues.apache.org/jira/browse/HBASE-12261 > Project: HBase > Issue Type: Bug > Components: build, site > Affects Versions: 2.0.0 > Reporter: Elliott Clark > Assignee: Elliott Clark > Fix For: 2.0.0, 0.98.8, 0.99.2 > > Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch > > > We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. > Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)