Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DE4BB17C15 for ; Mon, 6 Oct 2014 19:10:34 +0000 (UTC) Received: (qmail 71322 invoked by uid 500); 6 Oct 2014 19:10:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 71275 invoked by uid 500); 6 Oct 2014 19:10:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 71263 invoked by uid 99); 6 Oct 2014 19:10:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 19:10:34 +0000 Date: Mon, 6 Oct 2014 19:10:34 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12176) WALCellCodec Encoders support for non-KeyValue Cells MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160737#comment-14160737 ] Anoop Sam John commented on HBASE-12176: ---------------------------------------- bq.We serialize as we did KeyValues still, right? Not really. We were serializing considering the Cell nature I would say. The individual components like rk, cf, q, tags etc were taken and serialized (either direct or compressed way). The KV convert was needed to get buffer and write the ts, type and value parts together as one unit of byte[]. This part also we change to cell way now. So it was not fully in KV way serialize and now also. Hope I make it clear with explanation. Because of this new Codec may be not needed. This is Cell codecs only. The Encryptor names are confusing but as these were public, could not change them. What do you say Stack? bq.Do we write into WAL the codecs used? Yes. After some recent patch commit. > WALCellCodec Encoders support for non-KeyValue Cells > ---------------------------------------------------- > > Key: HBASE-12176 > URL: https://issues.apache.org/jira/browse/HBASE-12176 > Project: HBase > Issue Type: Improvement > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0, 0.99.1 > > Attachments: HBASE-12176.patch > > > Now in all Encoder returned by WALCellCodec and SecureWALCellCodec it is assumed that it will get only KeyValues. If not it just throws IOE. Now we support Cells through out in write path as well and these Encoders should support non KV cells as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)