Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F3B017B24 for ; Mon, 6 Oct 2014 18:49:35 +0000 (UTC) Received: (qmail 690 invoked by uid 500); 6 Oct 2014 18:49:35 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 645 invoked by uid 500); 6 Oct 2014 18:49:35 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 631 invoked by uid 99); 6 Oct 2014 18:49:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 18:49:35 +0000 Date: Mon, 6 Oct 2014 18:49:35 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12176) WALCellCodec Encoders support for non-KeyValue Cells MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160692#comment-14160692 ] stack commented on HBASE-12176: ------------------------------- What is the value of this patch [~anoop.hbase]? Just the removal of check for KeyValue? We serialize as we did KeyValues still, right? To serialize otherwise, we'd create a different WALCellCodec type? Do we write into WAL the codecs used? (I've not looked). > WALCellCodec Encoders support for non-KeyValue Cells > ---------------------------------------------------- > > Key: HBASE-12176 > URL: https://issues.apache.org/jira/browse/HBASE-12176 > Project: HBase > Issue Type: Improvement > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0, 0.99.1 > > Attachments: HBASE-12176.patch > > > Now in all Encoder returned by WALCellCodec and SecureWALCellCodec it is assumed that it will get only KeyValues. If not it just throws IOE. Now we support Cells through out in write path as well and these Encoders should support non KV cells as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)