Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7491917963 for ; Wed, 1 Oct 2014 18:28:34 +0000 (UTC) Received: (qmail 65718 invoked by uid 500); 1 Oct 2014 18:28:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 65675 invoked by uid 500); 1 Oct 2014 18:28:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 65663 invoked by uid 99); 1 Oct 2014 18:28:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 18:28:34 +0000 Date: Wed, 1 Oct 2014 18:28:34 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-12130) HBASE-11980 calls hflush and hsync doing near double the syncing work MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155253#comment-14155253 ] stack commented on HBASE-12130: ------------------------------- [~anoop.hbase] No sir. We are moving off the old calls and on to what is in Syncable (output.sync does a hflush internally). Thanks for review. > HBASE-11980 calls hflush and hsync doing near double the syncing work > --------------------------------------------------------------------- > > Key: HBASE-12130 > URL: https://issues.apache.org/jira/browse/HBASE-12130 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0, 0.99.1 > Reporter: stack > Assignee: stack > Priority: Critical > Attachments: 12130.txt, Screen Shot 2014-09-30 at 9.17.09 PM.png > > > The HBASE-11980 change has us doing hflush and hsync every time we call sync (noticed profiling). Fix. Let me expose as config calling one or the other. -- This message was sent by Atlassian JIRA (v6.3.4#6332)