Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 12 Oct 2014 03:36:34 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12743271.1411409604000.248292.1413084994041@Atlassian.JIRA>
In-Reply-To: <JIRA.12743271.1411409604000@Atlassian.JIRA>
References: <JIRA.12743271.1411409604000@Atlassian.JIRA>
 <JIRA.12743271.1411409604852@arcas>
Subject: [jira] [Commented] (HBASE-12053) SecurityBulkLoadEndPoint set 777
 permission on input data files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168500#comment-14168500 ] 

Enis Soztutar commented on HBASE-12053:
---------------------------------------

I'm +1 for this patch, but would be more comfortable if we can get another review. cc [~andrew.purtell@gmail.com], [~toffer].  

> SecurityBulkLoadEndPoint set 777 permission on input data files 
> ----------------------------------------------------------------
>
>                 Key: HBASE-12053
>                 URL: https://issues.apache.org/jira/browse/HBASE-12053
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>             Fix For: 2.0.0, 0.98.8, 0.99.1
>
>         Attachments: HBASE-12053.patch
>
>
> We have code in SecureBulkLoadEndpoint#secureBulkLoadHFiles
> {code}
>               LOG.trace("Setting permission for: " + p);
>               fs.setPermission(p, PERM_ALL_ACCESS);
> {code}
> This is against the point we use staging folder for secure bulk load. Currently we create a hidden staging folder which has ALL_ACCESS permission and we  use "doAs" to move input files into staging folder. Therefore, we should not set 777 permission on the original input data files but files in staging folder after move. 
> This may comprise security setting especially when there is an error & we move the file with 777 permission back. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)