Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 23 Oct 2014 18:13:34 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12738192.1409551440000.324640.1414088014607@Atlassian.JIRA>
In-Reply-To: <JIRA.12738192.1409551440000@Atlassian.JIRA>
References: <JIRA.12738192.1409551440000@Atlassian.JIRA>
 <JIRA.12738192.1409551440875@arcas>
Subject: [jira] [Commented] (HBASE-11870) Optimization : Avoid copy of key
 and value for tags addition in AC and VC
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-11870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181689#comment-14181689 ] 

Andrew Purtell commented on HBASE-11870:
----------------------------------------

lgtm

> Optimization : Avoid copy of key and value for tags addition in AC and VC
> -------------------------------------------------------------------------
>
>                 Key: HBASE-11870
>                 URL: https://issues.apache.org/jira/browse/HBASE-11870
>             Project: HBase
>          Issue Type: Improvement
>          Components: Performance, security
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: HBASE-11870.patch
>
>
> In AC and VC we have to add the per cell ACL tags/ visibility tags to Cells. We get KeyValue objects and which need one backing array with key,value and tags. So in order to add a tag we have to recreate buffer the and copy the entire key , value and tags.  We can avoid this
> Create a new Cell impl which wraps the original Cell and fro the non tag parts just refer this old buffer.
> This will contain a byte[] state for the tags part.
> Also we have to ensure we deal with Cells n write path not KV.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)