Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44C14175CD for ; Tue, 7 Oct 2014 06:27:08 +0000 (UTC) Received: (qmail 2987 invoked by uid 500); 7 Oct 2014 06:26:33 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 2938 invoked by uid 500); 7 Oct 2014 06:26:33 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 2920 invoked by uid 99); 7 Oct 2014 06:26:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 06:26:33 +0000 Date: Tue, 7 Oct 2014 06:26:33 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-11815) Flush and compaction could just close the tmp writer if there is an exception MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161536#comment-14161536 ] Hudson commented on HBASE-11815: -------------------------------- FAILURE: Integrated in HBase-TRUNK #5627 (See [https://builds.apache.org/job/HBase-TRUNK/5627/]) HBASE-11815 Flush and compaction could just close the tmp writer if there (ramkrishna: rev eb6f196395b4462ebabbaf1049d919533ae1875f) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlusher.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java > Flush and compaction could just close the tmp writer if there is an exception > ----------------------------------------------------------------------------- > > Key: HBASE-11815 > URL: https://issues.apache.org/jira/browse/HBASE-11815 > Project: HBase > Issue Type: Bug > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Trivial > Fix For: 2.0.0, 0.98.7, 0.99.1 > > Attachments: HBASE-11815.patch, HBASE-11815_0.98.patch, HBASE-11815_1.patch, HBASE-11815_2.patch, HBASE-11815_2.patch > > > A minor change. > {code} > try { > flushed = performFlush(scanner, writer, smallestReadPoint); > } finally { > finalizeWriter(writer, cacheFlushId, status); > } > {code} > Whenever there is a failure during flush we should close the writer but adding the meta data and setting the status would not be needed. > {code} > status.setStatus("Flushing " + store + ": appending metadata"); > writer.appendMetadata(cacheFlushSeqNum, false); > status.setStatus("Flushing " + store + ": closing flushed file"); > writer.close(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)